[PATCH] D56318: [HIP] Fix size_t for MSVC environment
John McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jan 4 11:12:58 PST 2019
rjmccall added a comment.
No, no, I understand that you're not changing pointer sizes, but this is one example of trying to match the ABI of the target environment, and I'm trying to understand how far that goes. What does it mean to be in the "MSVC" environment when you're actually just compiling for the GPU? Why are you using OS headers in the first place? Do you need struct layout to match MSVC (presumably on x86-64)? What should happen with the C++ ABI?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56318/new/
https://reviews.llvm.org/D56318
More information about the cfe-commits
mailing list