[PATCH] D55933: [Sema] Do not print default template parameters.
Clement Courbet via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Jan 4 04:14:17 PST 2019
courbet added inline comments.
================
Comment at: lib/AST/TypePrinter.cpp:179
+ // `X<Some::Class>` gets canonicalized to `X<float, int>`. We disable
+ // canonicalization so that `printTag()`` can see the template parameters as
+ // written.
----------------
Quuxplusone wrote:
> Nit: there's an extra ` on this line.
>
> I think I vaguely understand the purpose of this switch now. It feels ugly, but I have no concrete suggestion for improvement. Do you not need a case here to delay canonicalization of `X<Some::Class>&` also?
Indeed. Fixed + added tests.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55933/new/
https://reviews.llvm.org/D55933
More information about the cfe-commits
mailing list