[PATCH] D55865: [ObjC] Add a new attribute to opt-out of implicit callee retain/release in ARC

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 3 20:38:09 PST 2019


rjmccall added a comment.

Sorry, I keep coming up with small tweaks to the documentation.  These should be the last of them, so if Aaron's also satisfied, feel free to commit with those modifications.



================
Comment at: clang/docs/AutomaticReferenceCounting.rst:1788
+    // ...
+  }
+
----------------
Consider adding a paragraph describing how to test for support for this attribute.


================
Comment at: clang/include/clang/Basic/AttrDocs.td:3801
+Likewise, when applied to a strong local variable, that variable becomes
+``const`` and is considered externally-retained.
+}]; }
----------------
Please add a paragraph saying that this attribute has no effect when ARC isn't enabled.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55865/new/

https://reviews.llvm.org/D55865





More information about the cfe-commits mailing list