[PATCH] D56090: Add a matcher for members of an initializer list expression
Hyrum Wright via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Jan 3 09:34:47 PST 2019
hwright added inline comments.
================
Comment at: include/clang/ASTMatchers/ASTMatchers.h:3527
+ return N < Node.getNumInits() &&
+ InnerMatcher.matches(*Node.getInit(N)->IgnoreParenImpCasts(), Finder,
+ Builder);
----------------
aaron.ballman wrote:
> I'm not certain we want the `IgnoreParenImpCasts()` here -- what if someone wants to match an initializer that uses one of those properties?
The `hasArg` implementation directly above has the same call to `IgnoreParenImpCasts()`. Is it also in error? (It would seem that they should both be consistent.)
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56090/new/
https://reviews.llvm.org/D56090
More information about the cfe-commits
mailing list