[PATCH] D55994: [clangd] Check preceding char when completion triggers on ':' or '>'

Jan Korous via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 3 02:50:20 PST 2019


jkorous added a comment.

@hokein I think you are correct. I meant that it would be possible to make LSP more generic by using trigger strings instead of trigger characters..
@ilya-biryukov Yes, that's true. I would still expect some performance gain in more restrictive filtering on client's side - not sure how big though. Anyway, seems like LSP folks think character + trigger context is good enough. For example here:
https://github.com/Microsoft/language-server-protocol/issues/138


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55994/new/

https://reviews.llvm.org/D55994





More information about the cfe-commits mailing list