[PATCH] D56226: [clang-format] square parens that are followed by '=' are not Objective-C message sends

Jan Korous via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jan 3 02:07:45 PST 2019


jkorous added a comment.

Hi Alex, thanks for fixing this.

I assume chance of testing an Objective-C header with assignment to method result without any other specifically Objective-C (detectable) construct is significantly lower than chance of testing a C99 header with designated initializers. In other words - having potential for false Objective-C negatives in `parseSquare()` is probably fine given the context. Is that right?

If my assumption is correct I'd say LGTM unless anyone says otherwise within 1 week.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56226/new/

https://reviews.llvm.org/D56226





More information about the cfe-commits mailing list