[PATCH] D56113: [OpenMP] Replace predetermined shared for const variable

Wed Jan 2 13:50:54 PST 2019

jdenny marked 2 inline comments as done.
jdenny added a comment.

In D56113#1342879 <https://reviews.llvm.org/D56113#1342879>, @ABataev wrote:

> But you will need another serie of patches for `reduction` and `linear` clauses to update their error messages.

Those already had their own checks for const.  I'm not aware of any cases not handled, and the test suite does pass after my patch.

By the way, is there any value to keeping the predetermined shared for const if -openmp-version=3.1 or earlier?

>> Sorry, I misunderstood your first response.  When I try an atomic write to the shared variable, the difference between the uncombined and combined target teams directive affects functionality when targeting multicore.  Does that matter?
> 
> Yes, I'm aware if this problem. But I don't think it is very important and can cause serious problems in user code. If you think that it is worth to fix this prblem, you can go ahead and fix it.

No, not worthwhile for me right now.  I just wanted to point it out in passing in case it might matter to someone.  Does a bugzilla seem worthwhile to you?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56113/new/

https://reviews.llvm.org/D56113