[PATCH] D55994: [clangd] Check preceding char when completion triggers on ':' or '>'

Jan Korous via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Jan 2 08:47:02 PST 2019


jkorous added a comment.

This looks like a work around LSP imperfection indeed.

Are you going to push for change in LSP? Something like `CompletionOptions/triggerCharacters` -> `CompletionOptions/triggerStrings`?

  export interface CompletionOptions {
  	/**
  	 * The server provides support to resolve additional
  	 * information for a completion item.
  	 */
  	resolveProvider?: boolean;
  
  	/**
  	 * The characters that trigger completion automatically.
  	 */
  	triggerCharacters?: string[];
  }

https://microsoft.github.io/language-server-protocol/specification


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55994/new/

https://reviews.llvm.org/D55994





More information about the cfe-commits mailing list