[PATCH] D56160: [clang-tidy] modernize-use-trailing-return check

Eugene Zelenko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Dec 30 11:10:32 PST 2018


Eugene.Zelenko added a comment.

Please mention new check in Release Notes and list of checks. It'll be good idea to used add_new_check.py.



================
Comment at: clang-tidy/modernize/UseTrailingReturnCheck.cpp:22
+// very similar to UseOverrideCheck
+SourceLocation findTrailingReturnTypeLocation(const CharSourceRange &range,
+                                              const ASTContext &ctx,
----------------
Please use static instead of anonymous namespace. Same for other function. See LLVM coding guidelines.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56160/new/

https://reviews.llvm.org/D56160





More information about the cfe-commits mailing list