[PATCH] D56149: [sanitizer_common] Rewrite more Posix tests to use asserts

Kamil Rytarowski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Dec 29 08:44:07 PST 2018


krytarowski added inline comments.


================
Comment at: test/sanitizer_common/TestCases/Posix/devname_r.cc:21
 #if defined(__NetBSD__)
-  if (devname_r(st.st_rdev, type, name, sizeof(name)))
-    exit(1);
+  assert(!devname_r(st.st_rdev, type, name, sizeof(name)));
 #else
----------------
While there.. devname_r has a broken interceptor for !NetBSD. Wrong return type.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56149/new/

https://reviews.llvm.org/D56149





More information about the cfe-commits mailing list