[PATCH] D56136: [compiler-rt] [sanitizer_common] Add tests for more stdio.h functions
Kamil Rytarowski via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sat Dec 29 08:28:17 PST 2018
krytarowski added inline comments.
================
Comment at: test/sanitizer_common/TestCases/Posix/feof_fileno_ferror.cc:38
+
+ fclose(fp);
+ return 0;
----------------
mgorny wrote:
> krytarowski wrote:
> > krytarowski wrote:
> > > `assert(!fclose(fp));`
> > alternatively `!= EOF`
> It will fail most likely, due to us closing the fd before. However, I'm not sure if we want to strictly rely on this error condition.
Ah, OK. Please just add a comment that this call might fail.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56136/new/
https://reviews.llvm.org/D56136
More information about the cfe-commits
mailing list