[PATCH] D56136: [compiler-rt] [sanitizer_common] Add tests for more stdio.h functions

Michał Górny via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Dec 29 06:56:42 PST 2018


mgorny added inline comments.


================
Comment at: test/sanitizer_common/TestCases/Posix/feof_fileno_ferror.cc:38
+
+  fclose(fp);
+  return 0;
----------------
krytarowski wrote:
> krytarowski wrote:
> > `assert(!fclose(fp));`
> alternatively `!= EOF`
It will fail most likely, due to us closing the fd before. However, I'm not sure if we want to strictly rely on this error condition.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56136/new/

https://reviews.llvm.org/D56136





More information about the cfe-commits mailing list