[PATCH] D56136: [compiler-rt] [sanitizer_common] Add tests for more stdio.h functions
Kamil Rytarowski via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Dec 28 13:32:25 PST 2018
krytarowski added inline comments.
================
Comment at: test/sanitizer_common/TestCases/Posix/feof_fileno_ferror.cc:7
+int main(int argc, char **argv) {
+ FILE *fp;
+ int fd;
----------------
Please move local variable declaration to the first line used (whenever possible)
================
Comment at: test/sanitizer_common/TestCases/Posix/fgetc_ungetc_getc.cc:6
+int main(int argc, char **argv) {
+ FILE *fp;
+
----------------
`FILE *fp = fp = fopen(argv[0], "r");`
Repository:
rCRT Compiler Runtime
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56136/new/
https://reviews.llvm.org/D56136
More information about the cfe-commits
mailing list