[PATCH] D55915: [Driver] Make -fno-omit-frame-pointer imply -mno-omit-leaf-frame-pointer

Thu Dec 27 10:34:41 PST 2018

rnk added inline comments.

================
Comment at: test/Driver/cl-options.c:177
 // RUN: %clang_cl --target=i686-pc-win32 -Werror /Oy- /O2 -### -- %s 2>&1 | FileCheck -check-prefix=Oy_2 %s
-// Oy_2: -momit-leaf-frame-pointer
+// Oy_2: -mdisable-fp-elim
 // Oy_2: -O2
----------------
tabloid.adroit wrote:
> chandlerc wrote:
> > Do we want to also change behavior for the CL options? We should discuss this w/ the Windows folks at least....
> Sure. It would be great to have them to confirm.
> 
I'd say this behavior change is desired. I confirmed it's what MSVC does with /Oy-, which is their spelling for this. It also doesn't look like intentional behavior that we implemented to optimize size for 32-bit windows, based on this list of issues here:
https://bugs.llvm.org/showdependencytree.cgi?id=26299&hide_resolved=0
It has the potential to regress code size on i686-windows-msvc, but I don't think 32-bit size really matters at this point. If anything, better stack traces would be preferred.

Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55915/new/

https://reviews.llvm.org/D55915