[PATCH] D56095: [gn build] Add check-clang target and make it work

Petr Hosek via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 26 18:51:51 PST 2018


phosek added inline comments.


================
Comment at: llvm/utils/gn/secondary/llvm/triples.gni:10
+} else {
+  assert(false, "missing host_cpu " + host_cpu)
 }
----------------
I don't think `host_cpu` would ever be missing since it's detected by GN (unless it's a new architecture that GN doesn't recognize), should this rather be `unsupported host_cpu` or something along those lines?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56095/new/

https://reviews.llvm.org/D56095





More information about the cfe-commits mailing list