[PATCH] D56065: [gn build] Make NOSORT line actually work

[Nico Weber via Phabricator via cfe-commits]

thakis created this revision.
thakis added a reviewer: phosek.

GN wants the NOSORT line to be the first line of a comment block, not the last line.

I sent https://gn-review.googlesource.com/c/gn/+/3560 to support having it in the last line too, but since it will be a while until everyone has that change even if it's expected, use the form that works today.


https://reviews.llvm.org/D56065

Files:
  llvm/utils/gn/secondary/clang/lib/Headers/BUILD.gn


Index: llvm/utils/gn/secondary/clang/lib/Headers/BUILD.gn
===================================================================
--- llvm/utils/gn/secondary/clang/lib/Headers/BUILD.gn
+++ llvm/utils/gn/secondary/clang/lib/Headers/BUILD.gn
@@ -34,9 +34,9 @@
     ":arm_headers",
   ]
 
+  # NOSORT
   # Tell `gn format` to not reorder the sources list: Its order matches CMake,
   # and the ordering is alphabetical but ignores leading underscores.
-  # NOSORT
   sources = [
     "adxintrin.h",
     "altivec.h",


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D56065.179474.patch
Type: text/x-patch
Size: 510 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181224/f94e3bc7/attachment.bin>