[PATCH] D55646: [ASTImporter] Make ODR diagnostics warning by default
Aleksei Sidorin via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Dec 23 00:05:52 PST 2018
a_sidorin added subscribers: bruno, aaron.ballman, rsmith.
a_sidorin added a comment.
Hello Endre.
I agree that it doesn't make sense to have 'errors' in AST merging tools, and the changes for ASTImporter part are welcome. However, I don't feel so positive to modules support changes and I don't think we are allowed to change this. @aaron.ballman, @rsmith what do you think?
@bruno, you're the original author of the related Sema code. What do you think, should this be a warning or an error in Sema?
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55646/new/
https://reviews.llvm.org/D55646
More information about the cfe-commits
mailing list