[PATCH] D55853: Ignore ConstantExpr in IgnoreParens

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith accepted this revision.
rsmith added a comment.
This revision is now accepted and ready to land.

LGTM with `s/ConstantExpr/FullExpr/`.



================
Comment at: clang/lib/AST/Expr.cpp:2550
     }
+    if (ConstantExpr *CE = dyn_cast<ConstantExpr>(E)) {
+      E = CE->getSubExpr();
----------------
Does this pass the tests if you use `FullExpr` here instead? I don't think we should be treating `ConstantExpr` and  other `FullExpr`s differently.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55853/new/

https://reviews.llvm.org/D55853