[PATCH] D55640: [clang-tidy] Implement a check for large Objective-C type encodings 🔍

Stephane Moore via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 20 19:56:59 PST 2018


stephanemoore updated this revision to Diff 179239.
stephanemoore marked 6 inline comments as done.
stephanemoore added a comment.

Changes:
• Assert on `EncodedDecl`.
• Mention default value in objc-type-encoding-size check notes.

Outstanding action items:
• Evaluate using `hasDeclContext` instead of `hasAncestor`.
• Include type encoding size information in diagnostic messages.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55640/new/

https://reviews.llvm.org/D55640

Files:
  clang-tidy/objc/CMakeLists.txt
  clang-tidy/objc/ObjCTidyModule.cpp
  clang-tidy/objc/TypeEncodingSizeCheck.cpp
  clang-tidy/objc/TypeEncodingSizeCheck.h
  docs/ReleaseNotes.rst
  docs/clang-tidy/checks/list.rst
  docs/clang-tidy/checks/objc-type-encoding-size.rst
  test/clang-tidy/objc-type-encoding-size.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55640.179239.patch
Type: text/x-patch
Size: 10221 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181221/b926cddd/attachment.bin>


More information about the cfe-commits mailing list