[PATCH] D21856: [Driver][OpenMP] Add support to create jobs for bundling actions.

Nico Weber via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 20 19:08:48 PST 2018


thakis added a comment.
Herald added a subscriber: guansong.

Sorry about the years-later question, but what's the motivation for shelling out to an external command here? In general, LLVM tries to use a library-based approach, and LLVM went e.g. through great lengths do use an integrated assembler so clang doesn't have to shell out to one. Concretely, why isn't there a clang/lib/OffloadBundle library that clang and clang-offload-bundler both use? Does the bundling have to happen out-of-process? And if so, why isn't the process something like `clang -cc1bundle` instead of a separate executable? It seems weird to make clang depend on another executable next to it.

I apologize for the clueless question.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D21856/new/

https://reviews.llvm.org/D21856





More information about the cfe-commits mailing list