[PATCH] D55823: [analyzer] Fix backward compatibility issue after D53280 'Emit an error for invalid -analyzer-config inputs'

Kristóf Umann via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 20 12:50:18 PST 2018


Szelethus marked an inline comment as done.
Szelethus added a comment.

Sure! I'm on my phone, and will be for a little while, can you commit on my behalf?



================
Comment at: lib/Driver/ToolChains/Clang.cpp:3700
+  // through them.
+  for (size_t Index = 0; Index < Args.size(); ++Index) {
+    if (StringRef(Args.getArgString(Index)).contains("-analyzer-config")) {
----------------
george.karpenkov wrote:
> NoQ wrote:
> > Needs an LLVM-style loop!~ :)
> Shouldn't this be under else- for the previous branch? Otherwise it seems that the option would be added twice.
I originally deleted that line, but I lost in somewhere :/


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55823/new/

https://reviews.llvm.org/D55823





More information about the cfe-commits mailing list