[PATCH] D55928: [OpenMP] Add flag for preventing the extension to 64 bits for the collapse loop counter

Alexey Bataev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 20 07:28:53 PST 2018


ABataev added inline comments.


================
Comment at: lib/Driver/ToolChains/Clang.cpp:4429
       Args.AddAllArgs(CmdArgs, options::OPT_fopenmp_cuda_blocks_per_sm_EQ);
+      Args.AddLastArg(CmdArgs, options::OPT_fopenmp_optimistic_collapse,
+                      options::OPT_fno_openmp_optimistic_collapse);
----------------
fno_openmp_optimistic_collapse is not a frontend option. better to check for
```
if (Args.hasFlag(options::OPT_fopenmp_optimistic_collapse,
                   options::OPT_fno_openmp_optimistic_collapse,
                   /*Default=*/false))
  CmdArgs.push_back("-fopenmp-optimistic-collapse");
```
here rather than in the frontend. In the frontend, you can just check for the presence of the fopenmp_optimistic_collapse flag


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55928/new/

https://reviews.llvm.org/D55928





More information about the cfe-commits mailing list