[PATCH] D55916: [clang] Replace getOS() == llvm::Triple::*BSD with isOS*BSD() [NFCI]

Michał Górny via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 20 02:35:29 PST 2018


mgorny added inline comments.


================
Comment at: lib/Basic/Targets/ARM.cpp:285
     default:
-      if (Triple.getOS() == llvm::Triple::NetBSD)
+      if (Triple.isOSNetBSD())
         setABI("apcs-gnu");
----------------
krytarowski wrote:
> Actually we could use IsNetBSD and IsOpenBSD here.
Good catch. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55916/new/

https://reviews.llvm.org/D55916





More information about the cfe-commits mailing list