[PATCH] D55890: [X86][SSE] Auto upgrade PADDS/PSUBS intrinsics to SADD_SAT/SSUB_SAT generic intrinsics (clang)

Craig Topper via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 19 11:35:01 PST 2018


craig.topper added inline comments.


================
Comment at: lib/CodeGen/CGBuiltin.cpp:9492
 static Value *EmitX86AddSubSatExpr(CodeGenFunction &CGF,
-                                   SmallVectorImpl<Value *> &Ops,
+                                   SmallVectorImpl<Value *> &Ops, bool IsSigned,
                                    bool IsAddition) {
----------------
While you're touching this line, can we just make that an ArrayRef instead of a SmallVectorImpl?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55890/new/

https://reviews.llvm.org/D55890





More information about the cfe-commits mailing list