[PATCH] D55543: [CodeGen] Fix assertion on throwing object with inlined inherited constructor and non-trivial destructor.

Volodymyr Sapsai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 19 10:58:02 PST 2018


vsapsai updated this revision to Diff 178921.
vsapsai added a comment.

- [ObjC++] Verify there are no unexpected calls.

`--implicit-check-not` seems reasonable approach in this case. It causes adding
`Inheritor` destructors but gives higher confidence there are no unexpected
calls in unexpected places.

Escaping a space after check-not pattern to avoid matching attribute
`disable-tail-calls`.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55543/new/

https://reviews.llvm.org/D55543

Files:
  clang/lib/CodeGen/CGClass.cpp
  clang/test/CodeGenCXX/inheriting-constructor-cleanup.cpp
  clang/test/CodeGenObjCXX/inheriting-constructor-cleanup.mm

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55543.178921.patch
Type: text/x-patch
Size: 4814 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181219/33cb294a/attachment-0001.bin>


More information about the cfe-commits mailing list