[PATCH] D55552: [Sema] Better static assert diagnostics for expressions involving temporaries.

Clement Courbet via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 19 06:50:29 PST 2018


courbet added inline comments.


================
Comment at: include/clang/AST/Stmt.h:847
+                   const ASTContext *Context = nullptr,
+                   bool PrintCanonicalTypes = false) const;
 
----------------
aaron.ballman wrote:
> I'm pretty wary of long lists of parameters that include booleans with default values. Why is `PrintCanonicalTypes` not part of the printing policy? I think that's where we should keep all the knobs relating to how the printing happens.
Good point, done.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55552/new/

https://reviews.llvm.org/D55552





More information about the cfe-commits mailing list