[PATCH] D55771: [AST] Store the callee and argument expressions of CallExpr in a trailing array.

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 17 20:06:15 PST 2018


rjmccall added a comment.

I agree with not packing the argument count in.



================
Comment at: include/clang/AST/Stmt.h:439
+    /// trailing objects belonging to CallExpr.
+    unsigned OffsetToTrailingObjects : 6;
   };
----------------
If we're not packing anything into these bits anyway, it would be really nice if this could just be loaded as a byte, i.e. if it were 8 bits wide and allocated at a bit offset that's a multiple of 8.  That should be reasonably maintainable with a modest amount of arithmetic and `static_assert`-ing.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55771/new/

https://reviews.llvm.org/D55771





More information about the cfe-commits mailing list