[PATCH] D55765: Fix use-after-free bug in Tooling.

Alexander Kornienko via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 17 18:06:29 PST 2018


alexfh added inline comments.


================
Comment at: include/clang/Tooling/Tooling.h:208
 std::unique_ptr<ASTUnit>
-buildASTFromCode(const Twine &Code, const Twine &FileName = "input.cc",
+buildASTFromCode(StringRef Code, const Twine &FileName = "input.cc",
                  std::shared_ptr<PCHContainerOperations> PCHContainerOps =
----------------
While we're here, can we change FileName and ToolName to StringRef too?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55765/new/

https://reviews.llvm.org/D55765





More information about the cfe-commits mailing list