[PATCH] D55793: [clang-tidy] Add duplicated access specifier readability check (PR25403)

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Dec 17 15:00:44 PST 2018


lebedev.ri added a comment.

Please add tests with preprocessor (`#if ...`) that will show that it ignores disabled code. e.g.:

  class ProbablyValid {
  private:
    int a;
  #if defined(ZZ)
  public:
    int b;
  #endif
  private:
    int c;
  protected:
    int d;
  public:
    int e;
  };


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55793/new/

https://reviews.llvm.org/D55793





More information about the cfe-commits mailing list