[PATCH] D55715: Add AddressSpace mangling to MS mode

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 14 15:02:30 PST 2018


rnk accepted this revision.
rnk added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: test/CodeGenCXX/mangle-address-space.cpp:7
+// CHECKNOOCL-LABEL: define {{.*}}void @_Z2f0Pc
+// WINNOOCL-LABEL: define {{.*}}void @"?f0@@YAXPEAD at Z"
+// CHECKOCL-LABEL: define {{.*}}void @_Z2f0PU9CLgenericc
----------------
erichkeane wrote:
> rnk wrote:
> > You know, now that we have a demangler, I wonder if we shouldn't add a RUN line like this to test that these names really do demangle properly:
> > `// RUN: %clang_cc1 %s ... -emit-bitcode -o - | llvm-nm -demangle - | FileCheck %s --check-prefix=DEMANGLED`
> I'm not sure how that would work, but I can take a look.
Any thoughts on this? I see, llvm-nm -demangle doesn't call the microsoft demangler.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55715/new/

https://reviews.llvm.org/D55715





More information about the cfe-commits mailing list