[PATCH] D50563: Fixed frontend clang tests in windows read-only container

Stella Stamenova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Dec 14 10:57:57 PST 2018


stella.stamenova requested changes to this revision.
stella.stamenova added inline comments.
This revision now requires changes to proceed.


================
Comment at: test/Frontend/output-failures.c:1
-// RUN: not %clang_cc1 -emit-llvm -o %S/doesnotexist/somename %s 2> %t
-// RUN: FileCheck -check-prefix=OUTPUTFAIL -input-file=%t %s
+// RUN: not %clang_cc1 -emit-llvm -o %ROOT%/doesnotexist/somename %s 2>&1 | FileCheck -check-prefix=OUTPUTFAIL %s
 
----------------
I don't think this is the right solution - more specifically, I don't think we should be blindly looking for a file in the root directory that we do not control and adding a new property in the configuration for it.

A better solution would be to use a %t file here (for example, %t.doesnotexist) and run your tests out of tree (see test_exec_root).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D50563/new/

https://reviews.llvm.org/D50563





More information about the cfe-commits mailing list