[PATCH] D55595: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin

Thu Dec 13 23:43:39 PST 2018

yvvan marked an inline comment as done.
yvvan added inline comments.

================
Comment at: clang-tidy/plugin/ClangTidyPlugin.cpp:11
 #include "../ClangTidy.h"
+#include "../ClangTidyForceLinker.h"
 #include "../ClangTidyModule.h"
----------------
yvvan wrote:
> lebedev.ri wrote:
> > yvvan wrote:
> > > It seems it had to go after #include "clang/Config/config.h" to have MPI checks enabled...
> > The includes should be auto-sorted by clang-format, so if that header needs some headers,
> > then it should include them, not hope they will already be included.
> > 
> True. Will fix tomorrow asap.
Damn, "config.h" is special and can only be included once.

Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55595/new/

https://reviews.llvm.org/D55595