[PATCH] D55640: [clang-tidy] Implement a check for large Objective-C type encodings 🔍

[Dave MacLachlan via Phabricator via cfe-commits]

dmaclach added inline comments.


================
Comment at: clang-tidy/objc/TypeEncodingSizeCheck.cpp:53
+    diag(Block->getCaretLocation(),
+         "Objective-C type encoding for block expression exceeds %0 "
+         "characters")
----------------
I found it very useful in my diagnostics to know how big it actually was. Can you add that?


================
Comment at: clang-tidy/objc/TypeEncodingSizeCheck.cpp:101
+  diag(EncodedDecl->getLocation(),
+       "Objective-C type encoding for %0 exceeds %1 characters")
+      << EncodedDecl << Threshold;
----------------
Can you add what the actual size was in the output?


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55640/new/

https://reviews.llvm.org/D55640