r349118 - Revert "Try to update the test to fix the breakage With the new warning, we are showing one more output in the test."

Adam Nemet via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 13 16:43:37 PST 2018


Author: anemet
Date: Thu Dec 13 16:43:36 2018
New Revision: 349118

URL: http://llvm.org/viewvc/llvm-project?rev=349118&view=rev
Log:
Revert "Try to update the test to fix the breakage With the new warning, we are showing one more output in the test."

This reverts commit r349064.

This wasn't updating the right test.  Causing (not the different line number
from the previous revert):

======================================================================
FAIL: test_diagnostic_warning (tests.cindex.test_diagnostics.TestDiagnostics)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/buildslave/jenkins/workspace/clang-stage1-configure-RA/llvm/tools/clang/bindings/python/tests/cindex/test_diagnostics.py", line 18, in test_diagnostic_warning
    self.assertEqual(len(tu.diagnostics), 2)
AssertionError: 1 != 2

Modified:
    cfe/trunk/bindings/python/tests/cindex/test_diagnostics.py

Modified: cfe/trunk/bindings/python/tests/cindex/test_diagnostics.py
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/bindings/python/tests/cindex/test_diagnostics.py?rev=349118&r1=349117&r2=349118&view=diff
==============================================================================
--- cfe/trunk/bindings/python/tests/cindex/test_diagnostics.py (original)
+++ cfe/trunk/bindings/python/tests/cindex/test_diagnostics.py Thu Dec 13 16:43:36 2018
@@ -15,7 +15,7 @@ import unittest
 class TestDiagnostics(unittest.TestCase):
     def test_diagnostic_warning(self):
         tu = get_tu('int f0() {}\n')
-        self.assertEqual(len(tu.diagnostics), 2)
+        self.assertEqual(len(tu.diagnostics), 1)
         self.assertEqual(tu.diagnostics[0].severity, Diagnostic.Warning)
         self.assertEqual(tu.diagnostics[0].location.line, 1)
         self.assertEqual(tu.diagnostics[0].location.column, 11)




More information about the cfe-commits mailing list