[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker
MyDeveloperDay via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Dec 13 11:54:40 PST 2018
MyDeveloperDay updated this revision to Diff 178108.
MyDeveloperDay marked an inline comment as done.
MyDeveloperDay added a comment.
Addressing review comments
- don't add [[nodiscard]] onto function taking template arguments
- add more unit tests to cover other discard possibilities [[clang::warn_unused_result]],[[gcc::warn_unused_result]]
- improve the documentation to help explain when the [[nodiscard]] will/will not be applied
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55433/new/
https://reviews.llvm.org/D55433
Files:
clang-tidy/modernize/CMakeLists.txt
clang-tidy/modernize/ModernizeTidyModule.cpp
clang-tidy/modernize/UseNodiscardCheck.cpp
clang-tidy/modernize/UseNodiscardCheck.h
docs/ReleaseNotes.rst
docs/clang-tidy/checks/list.rst
docs/clang-tidy/checks/modernize-use-nodiscard.rst
test/clang-tidy/modernize-use-nodiscard-clang-unused.cpp
test/clang-tidy/modernize-use-nodiscard-cxx11.cpp
test/clang-tidy/modernize-use-nodiscard-gcc-unused.cpp
test/clang-tidy/modernize-use-nodiscard-no-macro.cpp
test/clang-tidy/modernize-use-nodiscard.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55433.178108.patch
Type: text/x-patch
Size: 22893 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20181213/4865b1ea/attachment-0001.bin>
More information about the cfe-commits
mailing list