[PATCH] D55649: [clangd] Enable cross-namespace completions by default in clangd

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 13 07:14:58 PST 2018


kadircet added inline comments.


================
Comment at: clangd/tool/ClangdMain.cpp:144
         "can insert scope qualifiers."),
-    cl::init(false), cl::Hidden);
+    cl::init(true));
 
----------------
ioeric wrote:
> kadircet wrote:
> > why not keep it hidden ?
> We hid the flag because the feature was experimental. Now that it's the default, I think it makes sense to expose the flag.
I wouldn't expect anyone to turn it off, but not that important.


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55649/new/

https://reviews.llvm.org/D55649





More information about the cfe-commits mailing list