[PATCH] D53699: [ASTImporter] Fix inequality of functions with different attributes

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 13 07:11:18 PST 2018


martong marked 4 inline comments as done.
martong added inline comments.


================
Comment at: lib/AST/ASTStructuralEquivalence.cpp:302
+/// is inspired by ASTContext::mergeFunctionTypes(), we compare calling
+/// conventions bits but must not compare some other bits, e.g. the noreturn
+/// bit.
----------------
shafik wrote:
> This comment is confusing b/c it looks like the noreturn bits are the only one you are not checking.
Ok, I have removed that part of the comment.


================
Comment at: unittests/AST/StructuralEquivalenceTest.cpp:373
 
+TEST_F(StructuralEquivalenceFunctionTest,
+    FunctionsWithDifferentAttributesButSameTypesShouldBeEqual) {
----------------
shafik wrote:
> Can we get some more tests to be a little more thorough and can we also get a test where it is expected to to be false as well?
Ok, I have adder a few more tests and renamed the existing one.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53699/new/

https://reviews.llvm.org/D53699





More information about the cfe-commits mailing list