[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 13 06:38:53 PST 2018


JonasToth added inline comments.


================
Comment at: test/clang-tidy/modernize-use-nodiscard.cpp:183
+    // CHECK-MESSAGES-NOT: warning:
+    // CHECK-FIXES: bool f33(T&) const
+    
----------------
No warning -> No fix -> You can ellide the `CHECK-FIXES` here and elsewhere. FileCheck is not confused by that :)
You don't need to specify that you dont expect a warning, too, because every warning that is not handled by `CHECK-MESSAGES`/`CHECK-NOTES` will result in a failed test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55433/new/

https://reviews.llvm.org/D55433





More information about the cfe-commits mailing list