[PATCH] D55245: [clang-tidy] Add the abseil-duration-subtraction check

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Dec 13 05:58:18 PST 2018


JonasToth accepted this revision.
JonasToth added a comment.

LGTM with the doc-nit.



================
Comment at: docs/clang-tidy/checks/abseil-duration-subtraction.rst:33
+Note: As with other ``clang-tidy`` checks, it is possible that multiple fixes
+may overlap (as in the case of nested expressions), so not all occurences can
+be transformed in one run. Running ``clang-tidy`` multiple times will fix these
----------------
I think it the doc should be explicit that this is the case for nesting the subtraction expression the issue can occur. Otherwise it might be a bit confusing.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55245/new/

https://reviews.llvm.org/D55245





More information about the cfe-commits mailing list