[PATCH] D55044: [clang-tidy] check for Abseil make_unique

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 12 22:11:18 PST 2018


lebedev.ri requested changes to this revision.
lebedev.ri added inline comments.
This revision now requires changes to proceed.


================
Comment at: clang-tidy/abseil/MakeUniqueCheck.h:29
+/// \endcode
+class MakeUniqueCheck : public modernize::MakeSmartPtrCheck {
+public:
----------------
Ah, so there is a check already, i missed that somehow.
If the `modernize::MakeSmartPtrCheck` is not sufficient to the needs, **it** needs to be extended.

You should be adding an **alias**, and this isn't the right way to do so.
E.g. see D53771 on how to do that.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55044/new/

https://reviews.llvm.org/D55044





More information about the cfe-commits mailing list