[PATCH] D55044: [clang-tidy] check for Abseil make_unique

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added inline comments.


================
Comment at: docs/ReleaseNotes.rst:93
+
+  Checks for instances of initializing a `unique_ptr` with a direct call to
+  `new` and suggests using `absl::make_unique` instead.
----------------
Please use double `, not single ones to hightlight language constructs. Same in documentation.


================
Comment at: docs/clang-tidy/checks/abseil-make-unique.rst:10
+Replaces initialization of smart pointers:
+\code
+  std::unique_ptr<int> ptr = std::unique_ptr<int>(new int(1));
----------------
Please use .. code-block:: c++. See other checks documentation as example.


================
Comment at: docs/clang-tidy/checks/abseil-make-unique.rst:19
+
+per the Abseil tips and guidelines at https://abseil.io/tips/126.
----------------
Please use hyperlink like:

The `Abseil Style Guide <https://abseil.io/tips/126>`_ discusses this issue in more detail.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55044/new/

https://reviews.llvm.org/D55044