[PATCH] D55595: [clang-tidy] Share the forced linking code between clang-tidy tool and plugin

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 12 07:53:23 PST 2018


JonasToth added a comment.

In D55595#1328263 <https://reviews.llvm.org/D55595#1328263>, @steveire wrote:

> Can you say where else it is common in LLVM? I'm curious. Maybe those places could be changed too.


My "is common" is not quantified, I have seen it before :)

>From grepping "extern volatile":

- clang-tidy a lot
- clang/lib/Tooling/CompilationDatabase.cpp:398
- clang/lib/Tooling/Execution.cpp:100
- clang/tools/libclang/CIndex.cpp:8681
- clang/tools/libclang/CIndex.cpp:8675

Thats probably all places or is same idiom implementable with something else?


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55595/new/

https://reviews.llvm.org/D55595





More information about the cfe-commits mailing list