[PATCH] D53755: [ASTImporter] Remove import of definition from GetAlreadyImportedOrNull

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Dec 12 03:22:13 PST 2018


martong added a comment.

@shafik

> We need to make sure we are running the lldb test suite before committing and watching the bots to make sure the commit does not break them.

I just have tested this patch on macOS  and there seems to be no regression. Linux also seems to be without any regression. Very soon I am going to commit and I am going to monitor green.lab.llvm.org/green/view/LLDB/ for sign of any failure. I will revert in case of any failure asap.

Thanks for the review!


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D53755/new/

https://reviews.llvm.org/D53755





More information about the cfe-commits mailing list