r348858 - Revert "[PowerPC] Make no-PIC default to match GCC - CLANG"

Tue Dec 11 09:40:59 PST 2018

On Tue, Dec 11, 2018 at 12:07 PM Stefan Pintilie <stefanp at ca.ibm.com> wrote:
>
> Hi Aaron,
>
> Sorry about giving so little info.

No worries!

> The commit was reverted because it broke two test cases on an internal buildbot. The reason this was reverted so late was because this failure was buried underneath another set of failures on that same buildbot which initially hid the problem. I'm looking at the failures now and hopefully I'll have the change back in soon.

Ah, thank you for the information.

~Aaron

>
> Stefan
>
>
>
> From:        Aaron Ballman <aaron at aaronballman.com>
> To:        stefanp at ca.ibm.com
> Cc:        cfe-commits <cfe-commits at lists.llvm.org>
> Date:        2018/12/11 10:56 AM
> Subject:        Re: r348858 - Revert "[PowerPC] Make no-PIC default to match GCC - CLANG"
> ________________________________
>
>
>
> On Tue, Dec 11, 2018 at 10:50 AM Stefan Pintilie via cfe-commits
> <cfe-commits at lists.llvm.org> wrote:
> >
> > Author: stefanp
> > Date: Tue Dec 11 07:47:57 2018
> > New Revision: 348858
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=348858&view=rev
> > Log:
> > Revert "[PowerPC] Make no-PIC default to match GCC - CLANG"
> >
> > This reverts commit rL348299.
>
> When reverting a commit, you should explain why the commit was
> reverted as part of the commit message (this makes code archaeology
> much easier). Why was this reverted 500+ revisions after it landed?
>
> ~Aaron
>
> >
> > Modified:
> >     cfe/trunk/lib/Driver/ToolChains/Gnu.cpp
> >     cfe/trunk/test/Driver/clang-offload-bundler.c
> >     cfe/trunk/test/Driver/ppc-abi.c
> >
> > Modified: cfe/trunk/lib/Driver/ToolChains/Gnu.cpp
> > URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Driver/ToolChains/Gnu.cpp?rev=348858&r1=348857&r2=348858&view=diff
> > ==============================================================================
> > --- cfe/trunk/lib/Driver/ToolChains/Gnu.cpp (original)
> > +++ cfe/trunk/lib/Driver/ToolChains/Gnu.cpp Tue Dec 11 07:47:57 2018
> > @@ -2435,7 +2435,7 @@ bool Generic_GCC::isPICDefault() const {
> >    case llvm::Triple::x86_64:
> >      return getTriple().isOSWindows();
> >    case llvm::Triple::ppc64:
> > -    // Big endian PPC is PIC by default
> > +  case llvm::Triple::ppc64le:
> >      return !getTriple().isOSBinFormatMachO() && !getTriple().isMacOSX();
> >    case llvm::Triple::mips64:
> >    case llvm::Triple::mips64el:
> >
> > Modified: cfe/trunk/test/Driver/clang-offload-bundler.c
> > URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/clang-offload-bundler.c?rev=348858&r1=348857&r2=348858&view=diff
> > ==============================================================================
> > --- cfe/trunk/test/Driver/clang-offload-bundler.c (original)
> > +++ cfe/trunk/test/Driver/clang-offload-bundler.c Tue Dec 11 07:47:57 2018
> > @@ -115,7 +115,7 @@
> >  // CK-TEXTI: // __CLANG_OFFLOAD_BUNDLE____END__ openmp-x86_64-pc-linux-gnu
> >
> >  // CK-TEXTLL: ; __CLANG_OFFLOAD_BUNDLE____START__ host-powerpc64le-ibm-linux-gnu
> > -// CK-TEXTLL: @A = dso_local global i32 0
> > +// CK-TEXTLL: @A = global i32 0
> >  // CK-TEXTLL: define {{.*}}@test_func()
> >  // CK-TEXTLL: ; __CLANG_OFFLOAD_BUNDLE____END__ host-powerpc64le-ibm-linux-gnu
> >  // CK-TEXTLL: ; __CLANG_OFFLOAD_BUNDLE____START__ openmp-powerpc64le-ibm-linux-gnu
> >
> > Modified: cfe/trunk/test/Driver/ppc-abi.c
> > URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Driver/ppc-abi.c?rev=348858&r1=348857&r2=348858&view=diff
> > ==============================================================================
> > --- cfe/trunk/test/Driver/ppc-abi.c (original)
> > +++ cfe/trunk/test/Driver/ppc-abi.c Tue Dec 11 07:47:57 2018
> > @@ -13,12 +13,12 @@
> >  // RUN: %clang -target powerpc64-unknown-linux-gnu %s -### -o %t.o 2>&1 \
> >  // RUN:   -mcpu=a2q -mno-qpx | FileCheck -check-prefix=CHECK-ELFv1 %s
> >  // RUN: %clang -target powerpc64-unknown-linux-gnu %s -### -o %t.o 2>&1 \
> > -// RUN:   -mabi=elfv2 | FileCheck -check-prefix=CHECK-ELFv2-BE %s
> > +// RUN:   -mabi=elfv2 | FileCheck -check-prefix=CHECK-ELFv2 %s
> >
> >  // RUN: %clang -target powerpc64le-unknown-linux-gnu %s -### -o %t.o 2>&1 \
> >  // RUN:   | FileCheck -check-prefix=CHECK-ELFv2 %s
> >  // RUN: %clang -target powerpc64le-unknown-linux-gnu %s -### -o %t.o 2>&1 \
> > -// RUN:   -mabi=elfv1 | FileCheck -check-prefix=CHECK-ELFv1-LE %s
> > +// RUN:   -mabi=elfv1 | FileCheck -check-prefix=CHECK-ELFv1 %s
> >  // RUN: %clang -target powerpc64le-unknown-linux-gnu %s -### -o %t.o 2>&1 \
> >  // RUN:   -mabi=elfv2 | FileCheck -check-prefix=CHECK-ELFv2 %s
> >  // RUN: %clang -target powerpc64le-unknown-linux-gnu %s -### -o %t.o 2>&1 \
> > @@ -26,44 +26,8 @@
> >
> >  // CHECK-ELFv1: "-mrelocation-model" "pic" "-pic-level" "2"
> >  // CHECK-ELFv1: "-target-abi" "elfv1"
> > -// CHECK-ELFv1-LE: "-mrelocation-model" "static"
> > -// CHECK-ELFv1-LE: "-target-abi" "elfv1"
> >  // CHECK-ELFv1-QPX: "-mrelocation-model" "pic" "-pic-level" "2"
> >  // CHECK-ELFv1-QPX: "-target-abi" "elfv1-qpx"
> > -// CHECK-ELFv2: "-mrelocation-model" "static"
> > +// CHECK-ELFv2: "-mrelocation-model" "pic" "-pic-level" "2"
> >  // CHECK-ELFv2: "-target-abi" "elfv2"
> > -// CHECK-ELFv2-BE: "-mrelocation-model" "pic" "-pic-level" "2"
> > -// CHECK-ELFv2-BE: "-target-abi" "elfv2"
> > -
> > -// RUN: %clang -fPIC -target powerpc64-unknown-linux-gnu %s -### -o %t.o 2>&1 \
> > -// RUN:   | FileCheck -check-prefix=CHECK-ELFv1-PIC %s
> > -// RUN: %clang -fPIC -target powerpc64-unknown-linux-gnu %s -### -o %t.o 2>&1 \
> > -// RUN:   -mabi=elfv1 | FileCheck -check-prefix=CHECK-ELFv1-PIC %s
> > -// RUN: %clang -fPIC -target powerpc64-unknown-linux-gnu %s -### -o %t.o 2>&1 \
> > -// RUN:   -mabi=elfv1-qpx | FileCheck -check-prefix=CHECK-ELFv1-QPX-PIC %s
> > -// RUN: %clang -fPIC -target powerpc64-unknown-linux-gnu %s -### -o %t.o 2>&1 \
> > -// RUN:   -mcpu=a2q | FileCheck -check-prefix=CHECK-ELFv1-QPX-PIC %s
> > -// RUN: %clang -fPIC -target powerpc64-unknown-linux-gnu %s -### -o %t.o 2>&1 \
> > -// RUN:   -mcpu=a2 -mqpx | FileCheck -check-prefix=CHECK-ELFv1-QPX-PIC %s
> > -// RUN: %clang -fPIC -target powerpc64-unknown-linux-gnu %s -### -o %t.o 2>&1 \
> > -// RUN:   -mcpu=a2q -mno-qpx | FileCheck -check-prefix=CHECK-ELFv1-PIC %s
> > -// RUN: %clang -fPIC -target powerpc64-unknown-linux-gnu %s -### -o %t.o 2>&1 \
> > -// RUN:   -mabi=elfv2 | FileCheck -check-prefix=CHECK-ELFv2-PIC %s
> > -
> > -// RUN: %clang -fPIC -target powerpc64le-unknown-linux-gnu %s -### -o %t.o 2>&1 \
> > -// RUN:   | FileCheck -check-prefix=CHECK-ELFv2-PIC %s
> > -// RUN: %clang -fPIC -target powerpc64le-unknown-linux-gnu %s -### -o %t.o 2>&1 \
> > -// RUN:   -mabi=elfv1 | FileCheck -check-prefix=CHECK-ELFv1-PIC %s
> > -// RUN: %clang -fPIC -target powerpc64le-unknown-linux-gnu %s -### -o %t.o 2>&1 \
> > -// RUN:   -mabi=elfv2 | FileCheck -check-prefix=CHECK-ELFv2-PIC %s
> > -// RUN: %clang -fPIC -target powerpc64le-unknown-linux-gnu %s -### -o %t.o 2>&1 \
> > -// RUN:   -mabi=altivec | FileCheck -check-prefix=CHECK-ELFv2-PIC %s
> > -
> > -// CHECK-ELFv1-PIC: "-mrelocation-model" "pic" "-pic-level" "2"
> > -// CHECK-ELFv1-PIC: "-target-abi" "elfv1"
> > -// CHECK-ELFv1-QPX-PIC: "-mrelocation-model" "pic" "-pic-level" "2"
> > -// CHECK-ELFv1-QPX-PIC: "-target-abi" "elfv1-qpx"
> > -// CHECK-ELFv2-PIC: "-mrelocation-model" "pic" "-pic-level" "2"
> > -// CHECK-ELFv2-PIC: "-target-abi" "elfv2"
> > -
> >
> >
> >
> > _______________________________________________
> > cfe-commits mailing list
> > cfe-commits at lists.llvm.org
> > http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
>
>
>