[PATCH] D55534: [AST] Store "UsesADL" information in CallExpr.

[Eric Fiselier via Phabricator via cfe-commits]

EricWF marked 12 inline comments as done.
EricWF added a comment.

Address more review comments. Update incoming.



================
Comment at: include/clang/AST/Expr.h:2425
   CallExpr(const ASTContext &C, StmtClass SC, unsigned NumPreArgs,
-           unsigned NumArgs, EmptyShell Empty);
+           unsigned NumArgs, bool UsesADL, EmptyShell Empty);
 
----------------
riccibruno wrote:
> There is no need to pass this flag to the empty constructor
> since it is going to be deserialized in `ASTReaderStmt`.
> Only what is strictly needed to create the empty `CallExpr`
> is passed here. In fact if you wanted to pass the flag when creating
> the empty `CallExpr` you would have to update what is
> under `case EXPR_CALL:` in `ASTReader::ReadStmtFromStream`.
Ack. Thanks for the explanation.


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55534/new/

https://reviews.llvm.org/D55534