r348798 - Fix nits
Roman Lebedev via cfe-commits
cfe-commits at lists.llvm.org
Mon Dec 10 13:09:21 PST 2018
On Tue, Dec 11, 2018 at 12:07 AM Stephen Kelly via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
>
> Author: steveire
> Date: Mon Dec 10 13:04:04 2018
> New Revision: 348798
>
> URL: http://llvm.org/viewvc/llvm-project?rev=348798&view=rev
> Log:
> Fix nits
Can you *please* write proper commit messages, pretty please?
I have asked this two times already.
It will make reading through git log hard,
and is already making reading throughout the -commits mail hard.
> Modified:
> cfe/trunk/lib/AST/ASTDumper.cpp
>
> Modified: cfe/trunk/lib/AST/ASTDumper.cpp
> URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ASTDumper.cpp?rev=348798&r1=348797&r2=348798&view=diff
> ==============================================================================
> --- cfe/trunk/lib/AST/ASTDumper.cpp (original)
> +++ cfe/trunk/lib/AST/ASTDumper.cpp Mon Dec 10 13:04:04 2018
> @@ -100,12 +100,12 @@ namespace {
> void dumpTemplateArgumentListInfo(const TemplateArgumentListInfo &TALI);
> void dumpTemplateArgumentLoc(const TemplateArgumentLoc &A,
> const Decl *From = nullptr,
> - const char *label = nullptr);
> + const char *Label = nullptr);
> void dumpTemplateArgumentList(const TemplateArgumentList &TAL);
> void dumpTemplateArgument(const TemplateArgument &A,
> SourceRange R = SourceRange(),
> const Decl *From = nullptr,
> - const char *label = nullptr);
> + const char *Label = nullptr);
> template <typename SpecializationDecl>
> void dumpTemplateDeclSpecialization(const SpecializationDecl *D,
> bool DumpExplicitInst,
> @@ -678,8 +678,8 @@ void ASTDumper::dumpTemplateArgumentList
> }
>
> void ASTDumper::dumpTemplateArgumentLoc(const TemplateArgumentLoc &A,
> - const Decl *From, const char *label) {
> - dumpTemplateArgument(A.getArgument(), A.getSourceRange(), From, label);
> + const Decl *From, const char *Label) {
> + dumpTemplateArgument(A.getArgument(), A.getSourceRange(), From, Label);
> }
>
> void ASTDumper::dumpTemplateArgumentList(const TemplateArgumentList &TAL) {
> @@ -688,15 +688,14 @@ void ASTDumper::dumpTemplateArgumentList
> }
>
> void ASTDumper::dumpTemplateArgument(const TemplateArgument &A, SourceRange R,
> - const Decl *From, const char *label) {
> + const Decl *From, const char *Label) {
> dumpChild([=] {
> OS << "TemplateArgument";
> if (R.isValid())
> NodeDumper.dumpSourceRange(R);
>
> - if (From) {
> - dumpDeclRef(From, label);
> - }
> + if (From)
> + dumpDeclRef(From, Label);
>
> switch (A.getKind()) {
> case TemplateArgument::Null:
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
More information about the cfe-commits
mailing list