[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

[Roman Lebedev via Phabricator via cfe-commits]

lebedev.ri added a comment.

In D55433#1323757 <https://reviews.llvm.org/D55433#1323757>, @MyDeveloperDay wrote:

> a lot of projects aren't setup for c++17 yet which is needed for [[nodiscard]] to be allowed,


You can use `[[clang::warn_unused_result]]` for this evaluation, that does not require C++17.

> But the clang-tidy -fix doesn't break the build, the patch is large but nothing broke. (at compile time at least!)
> 
>   {F7661182} 

Uhm, so there wasn't a single true-positive in protobuf?


Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55433/new/

https://reviews.llvm.org/D55433