[PATCH] D55443: [test] Capture stderr from 'tar --version' call as well

[Michał Górny via Phabricator via cfe-commits]

mgorny added a comment.

Sorry, it seems that my reply didn't go through.



================
Comment at: test/lit.cfg.py:99
+        stdout=subprocess.PIPE,
+        stderr=subprocess.PIPE,
+        env={'LANG': 'C'})
----------------
MaskRay wrote:
> If you don't need stderr, remove `stderr=subprocess.PIPE,`
> 
> `subprocess.Popen followed by communicate()` can be replaced by `check_output`
> 
> `if 'GNU tar' in sout:` does not in Python 3 as `sout` would have type `bytes`, not `str`
I need to silence stderr. Given that `/dev/null` is not portable, and `subprocess.DEVNULL` requires py3.3+, capturing it is the simplest solution.

`check_output()` will throw when `tar` doesn't support version, i.e. it would break NetBSD completely instead of silencing the error.

I'll fix the type mismatch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55443/new/

https://reviews.llvm.org/D55443