[PATCH] D36527: Implemented P0428R2 - Familiar template syntax for generic lambdas
Hamza Sood via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Dec 7 08:04:47 PST 2018
hamzasood marked 6 inline comments as done.
hamzasood added inline comments.
================
Comment at: lib/AST/DeclPrinter.cpp:107-108
- void printTemplateParameters(const TemplateParameterList *Params);
+ void printTemplateParameters(const TemplateParameterList *Params,
+ bool OmitTemplateKW = false);
void printTemplateArguments(const TemplateArgumentList &Args,
----------------
rsmith wrote:
> Nit: I'd prefer splitting this into two functions (one that prints 'template', calls the other, then prints a space, and the other to print the actual template parameters) rather than passing a boolean flag.
Do you reckon that the boolean flag is okay for `TemplateParameterList::print`? I've left this change for now until that has been decided.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D36527/new/
https://reviews.llvm.org/D36527
More information about the cfe-commits
mailing list