[PATCH] D55433: [clang-tidy] Adding a new modernize use nodiscard checker

Fri Dec 7 07:14:10 PST 2018

MyDeveloperDay added a comment.

In D55433#1323106 <https://reviews.llvm.org/D55433#1323106>, @lebedev.ri wrote:

> Have you evaluated this on some major C++ projects yet?
>  I suspect this may have pretty low SNR.

Internally yes (on millions of lines), but you are correct high noise level, however resulting compiles showed a number of hard to find bugs most notably where empty()  function on custom container was being used when they meant clear(), this bug had gone undetected for 10+ years.

The idea came from guidance given in Jason Turner CppCon2018 talk, https://www.youtube.com/watch?v=DHOlsEd0eDE (about 14 minutes in)

"is it a logical error in your code to call this member function and discard the return value"... the room says yes!!

Repository:
  rCTE Clang Tools Extra

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55433/new/

https://reviews.llvm.org/D55433